I think your problem lies in the injection. 1/4 cup of salt put into a pork shoulder, or anything, is going to make it salty.
As far as dry, are you sure your thermo's are calibrated? Both, the one on the smoker, and the one in the shoulder. Where are you checking the temp in the smoker?
I...