I have collected coins for about 20 years, starting with proof sets, then adding circulation coins. I think I'm a bit obsessive/compulsive;
I can't stand to have an empty slot in the collectors albums.
I have every proof set from 1957 to the present, as well as most mint sets and
quite a few silver proof sets. I have a leather album for each type of coin during that period - penny, nickel, dime, quarter etc. I filled those with mostly coins from circulation but did buy a few harder to find coins. Going backwards from 57, I have a mishmash of coins that I found interesting - some with a little bullion value, some just "neat" or unusual. I've always liked the Morgan dollars and have quite a few of those.
They (and the Peace dollars) will actually have some value, depending on the price of silver.
The numismatic value determines a lot of the pricing for collectables. Some of the proof sets I bought were $3 - $4, while the next year's set
might be $60. I don't actively search for coins much anymore -although I always look through my change - and I just kind of hang on to
these.
As for investment metals, I have gold and silver coins. Mostly silver eagles - at least one roll (20 coins) from each year since they
were released in 1986. I also have some foreign rounds - Maple Leaf, Panda Bear, etc.
In my opinion the US Walking Liberty is the most beautiful silver coin in the world - but I might be a little biased.
I have a Saint Gaudens $20 gold piece that I'm proud of, and various other gold coins.
I seem to be more of a collector - I gather coins, but rarely release them. LOL (Although I did sell a few investment coins last
year when prices hit record highs.)
I have a coin dealer I trust that I have dealt with for decades. I think that's the best way to find the items you want and to get
good valuations for what you have. If you can find someone local who has been in business for a while, you might start there.
Pro tip - my dealer gets a HUGE batch of homemade fudge every Christmas.
Good grief, sorry for running on - this is way more than you wanted to hear! This is something I have enjoyed, so there is a risk
of me boring you to tears.